Repository navigation
Fix inverted rmdir() result in the POSIX and stdio adapters - #12
Merged
Merged
Conversation
rmdir() in the POSIX and stdio adapters returned false when the directory was removed and true when it wasn't, the opposite of every other adapter (and of mkdir()). Adds test/test_posix_fs, which runs the adapters against a real temp directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rUgoKJdB4U8fNS9HybY8S
Owner
|
Thanks for catching this, and for adding a test that shows the bug on master. The fix makes the POSIX and stdio adapters match the others. I'll give it a final look when I get a chance. Since the return value changes, I'll add a note to the CHANGELOG for anyone downstream who worked around the old behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rmdir()in the POSIX and stdio adapters returnedfalsewhen the directory was removed andtruewhen it wasn't, the opposite of every other adapter (and ofmkdir()).Adds
test/test_posix_fs, which runs the adapters against a real temp directory. The new tests fail on master and pass here.Testing:
pio test -e native. The new tests pass.test_file_store_compact_basic,test_dir_prefix_reload_indexandtest_dir_prefix_compactalready fail on master and are unchanged.